Skip to content

fix(tracing): Report the right units for CLS and TTFB [INGEST-1409] #5303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 23, 2022
Merged

fix(tracing): Report the right units for CLS and TTFB [INGEST-1409] #5303

merged 2 commits into from
Jun 23, 2022

Conversation

untitaker
Copy link
Member

  • ttfb.requestTime is multiplied times 1000 and is documented in a code comment as ms
  • Cumulative Layout Shift does not have a unit. A layout cannot shift by 10 milliseconds

@untitaker untitaker requested review from jan-auer and AbhiPrasad June 23, 2022 19:37
@AbhiPrasad AbhiPrasad changed the title fix: Report the right units for CLS and TTFB [INGEST-1409] fix(tracing): Report the right units for CLS and TTFB [INGEST-1409] Jun 23, 2022
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) June 23, 2022 19:38
untitaker
untitaker commented Jun 23, 2022
View reviewed changes
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.39 KB (added)
@sentry/browser - ES5 CDN Bundle (minified) 59.95 KB (added)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.17 KB (added)
@sentry/browser - ES6 CDN Bundle (minified) 53.57 KB (added)
@sentry/browser - Webpack (gzipped + minified) 19.96 KB (added)
@sentry/browser - Webpack (minified) 65.02 KB (added)
@sentry/react - Webpack (gzipped + minified) 19.98 KB (added)
@sentry/nextjs Client - Webpack (gzipped + minified) 44.23 KB (added)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 25.79 KB (added)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.26 KB (added)

@AbhiPrasad AbhiPrasad merged commit b52900f into master Jun 23, 2022
@AbhiPrasad AbhiPrasad deleted the fix/proper-units-measurements branch June 23, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@jan-auer jan-auer Awaiting requested review from jan-auer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@untitaker @AbhiPrasad